Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

Replace {i,getI}64ElementsAttr #403

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Replace {i,getI}64ElementsAttr #403

merged 1 commit into from
Jan 11, 2024

Conversation

marbre
Copy link
Contributor

@marbre marbre commented Jan 11, 2024 •
edited
Loading

Replaces {i,getI}64ElementsAttr with getI64TensorAttr.

Closes #402

@marbre marbre requested a review from simon-camp January 11, 2024 09:20
simon-camp
simon-camp suggested changes Jan 11, 2024
View reviewed changes
Copy link
Member

@simon-camp simon-camp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you replace i64ElementsAttr as well.

  • i64ElementsAttr(N, M, ctx) -> rewriter.getI64TensorAttr(SmallVector<int64_t>(N, M))

@marbre marbre force-pushed the getI64ElementsAttr branch from 9839822 to 62f78e5 Compare January 11, 2024 10:16
@marbre marbre changed the title Replace getI64ElementsAttr with use of rewriter Replace {i,getI}64ElementsAttr with rewriter Jan 11, 2024
@marbre marbre requested a review from simon-camp January 11, 2024 10:17
simon-camp
simon-camp previously approved these changes Jan 11, 2024
View reviewed changes
@marbre marbre force-pushed the getI64ElementsAttr branch from 62f78e5 to 989a71f Compare January 11, 2024 10:54
@marbre marbre changed the title Replace {i,getI}64ElementsAttr with rewriter Replace {i,getI}64ElementsAttr Jan 11, 2024
@marbre marbre requested a review from simon-camp January 11, 2024 10:57
@marbre
Replace using {i,getI}64ElementsAttr
7b65376 
Replaces `{i,getI}64ElementsAttr` with `getI64TensorAttr`.

Closes iml130#402
@marbre marbre force-pushed the getI64ElementsAttr branch from 989a71f to 7b65376 Compare January 11, 2024 11:01
@marbre marbre merged commit f9683c2 into iml130:main Jan 11, 2024
6 checks passed
@marbre marbre deleted the getI64ElementsAttr branch January 11, 2024 11:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@simon-camp simon-camp simon-camp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use rewriter instead of utility functions for attribute conversion
2 participants
@marbre @simon-camp