Skip to content

Commit

Permalink
Update to 8.7.5 full.
Browse files Browse the repository at this point in the history
  • Loading branch information
wasabii committed Feb 5, 2024
1 parent 340bf7f commit 469ff44
Show file tree
Hide file tree
Showing 4 changed files with 33 additions and 3 deletions.
2 changes: 1 addition & 1 deletion global.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
"rollForward": "latestFeature"
},
"msbuild-sdks": {
"IKVM.NET.Sdk": "8.7.5-pre.3"
"IKVM.NET.Sdk": "8.7.5"
}
}
30 changes: 30 additions & 0 deletions src/IKVM.Maven.Sdk.Tasks.Tests/MavenReferenceItemResolveTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -601,6 +601,36 @@ public void ExclusionsShouldExcludeSystemDependency()
t.ResolvedReferences.Should().NotContain(i => i.ItemSpec == "maven$com.sun:tools:jar:1.8.0");
}

[TestMethod]
public void CanResolveClassifiers()
{
var cacheFile = Path.GetTempFileName();

var engine = new Mock<IBuildEngine>();
var errors = new List<BuildErrorEventArgs>();
engine.Setup(x => x.LogErrorEvent(It.IsAny<BuildErrorEventArgs>())).Callback((BuildErrorEventArgs e) => { errors.Add(e); TestContext.WriteLine("ERROR: " + e.Message); });
engine.Setup(x => x.LogWarningEvent(It.IsAny<BuildWarningEventArgs>())).Callback((BuildWarningEventArgs e) => TestContext.WriteLine("WARNING: " + e.Message));
engine.Setup(x => x.LogMessageEvent(It.IsAny<BuildMessageEventArgs>())).Callback((BuildMessageEventArgs e) => TestContext.WriteLine(e.Message));
var t = new MavenReferenceItemResolve();
t.BuildEngine = engine.Object;
t.CacheFile = cacheFile;
t.Repositories = new[] { GetCentralRepositoryItem() };

var i1 = new TaskItem("edu.stanford.nlp:stanford-corenlp:4.5.5");
i1.SetMetadata(MavenReferenceItemMetadata.GroupId, "edu.stanford.nlp");
i1.SetMetadata(MavenReferenceItemMetadata.ArtifactId, "stanford-corenlp");
i1.SetMetadata(MavenReferenceItemMetadata.Version, "4.5.5");
i1.SetMetadata(MavenReferenceItemMetadata.Classifier, "models");
i1.SetMetadata(MavenReferenceItemMetadata.Scope, "compile");

t.References = new[] { i1 };

t.Execute().Should().BeTrue();
errors.Should().BeEmpty();

t.ResolvedReferences.Should().NotContain(i => i.ItemSpec == "maven$edu.stanford.nlp:stanford-corenlp:models:4.5.5");
}

}

}
2 changes: 1 addition & 1 deletion src/IKVM.Maven.Sdk.Tasks/IKVM.Maven.Sdk.Tasks.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="IKVM" Version="8.7.5-pre.3" />
<PackageReference Include="IKVM" Version="8.7.5" />
<PackageReference Include="Microsoft.Bcl.HashCode" Version="1.1.1" />
<PackageReference Include="Microsoft.Build" Version="16.9.0" PrivateAssets="All" />
<PackageReference Include="Microsoft.Build.Utilities.Core" Version="16.9.0" PrivateAssets="All" />
Expand Down
2 changes: 1 addition & 1 deletion src/IKVM.Maven.Sdk/IKVM.Maven.Sdk.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

<ItemGroup>
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="all" />
<PackageReference Include="IKVM" Version="8.7.5-pre.3" />
<PackageReference Include="IKVM" Version="8.7.5" />
</ItemGroup>

<ItemGroup>
Expand Down

0 comments on commit 469ff44

Please sign in to comment.