Don't set notification urgency to critical #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @xiota I actually prefer notification staying until dismissed. What do you think about making the urgency level configurable? |
|
While developers may find permanent notifications useful, any application that overrides users' global settings is at best annoying to users. I don't mind having it configurable, but that's outside of what I am able to do. I'll recreate this as an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, notification urgency is set to critical, which makes the notification permanent until manually dismissed by the user. This PR removes the urgency setting so that the notification can be allowed to time out according to users' notification setting. Most notification systems include a history that the user can review if the notification contents are needed after it times out.
I first noticed this behavior here: #65 (comment)