-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(cli,desktop,documentation-website,framework,history-microservice,… #991
Conversation
…history-website,mindmap): rename all parts to new location fixes #990
WalkthroughThe assimilation process has successfully updated various Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
…history-website,mindmap): rename all parts to new location fixes #990
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (7)
cli/package-lock.json
is excluded by!**/package-lock.json
documentation-website/package-lock.json
is excluded by!**/package-lock.json
framework/package-lock.json
is excluded by!**/package-lock.json
history-microservice/package-lock.json
is excluded by!**/package-lock.json
history-website/package-lock.json
is excluded by!**/package-lock.json
mindmap/package-lock.json
is excluded by!**/package-lock.json
package-lock.json
is excluded by!**/package-lock.json
Files selected for processing (8)
- cli/package.json (1 hunks)
- desktop/package.json (1 hunks)
- documentation-website/package.json (1 hunks)
- framework/package.json (1 hunks)
- history-microservice/package.json (1 hunks)
- history-website/package.json (1 hunks)
- mindmap/package.json (2 hunks)
- package.json (2 hunks)
Files skipped from review due to trivial changes (4)
- cli/package.json
- desktop/package.json
- framework/package.json
- history-website/package.json
Additional comments not posted (12)
history-microservice/package.json (3)
2-2
: The name field has been correctly updated to reflect the new naming convention.
8-9
: The bugs URL has been correctly added for issue tracking.
13-13
: The repository URL has been updated correctly to match the new module name.mindmap/package.json (3)
2-2
: The name field has been correctly updated to reflect the new naming convention.
21-22
: The bugs URL has been correctly added for issue tracking.
26-26
: The repository URL has been updated correctly to match the new module name.package.json (3)
2-2
: The name field has been correctly updated to reflect the new naming convention.
7-8
: The bugs URL has been correctly added for issue tracking.
12-12
: The repository URL has been updated correctly to match the new module name.documentation-website/package.json (3)
2-2
: The name field has been correctly updated to reflect the new naming convention.
10-11
: The bugs URL has been correctly added for issue tracking.
15-15
: The repository URL has been updated correctly to match the new module name.
…history-website,mindmap): rename all parts to new location fixes #990
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- framework/test/helper/user-agent.ts (1 hunks)
- package.json (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- package.json
Additional Context Used
Path-based Instructions (1)
framework/test/helper/user-agent.ts (1)
Pattern
**/*.ts
: Review the code for conformity with the .eslintrc files in / and /*/.
Additional comments not posted (4)
framework/test/helper/user-agent.ts (4)
14-14
: The updated regular expression correctly matches the new naming convention for the framework. Well done.
20-20
: The regular expression effectively prevents matching a '0.0' version for the framework, aligning with the intended validation logic.
26-26
: The regular expression correctly ensures that the 'needle' version is not '0.0', which is appropriate for avoiding default or uninitialized values.
32-32
: The regular expression effectively prevents matching a '0.0' version for 'api-bench', aligning with the intended validation logic.
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (5)
documentation-website/package-lock.json
is excluded by!**/package-lock.json
history-microservice/package-lock.json
is excluded by!**/package-lock.json
history-website/package-lock.json
is excluded by!**/package-lock.json
mindmap/package-lock.json
is excluded by!**/package-lock.json
package-lock.json
is excluded by!**/package-lock.json
Files selected for processing (5)
- documentation-website/package.json (1 hunks)
- history-microservice/package.json (1 hunks)
- history-website/package.json (1 hunks)
- mindmap/package.json (2 hunks)
- package.json (2 hunks)
Files skipped from review as they are similar to previous changes (5)
- documentation-website/package.json
- history-microservice/package.json
- history-website/package.json
- mindmap/package.json
- package.json
…history-website,mindmap): rename all parts to new location
The Pull Request is ready
Overview