Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 779 cleanup faq #1017

Merged
merged 11 commits into from
May 6, 2024
Merged

Issue 779 cleanup faq #1017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5b32718
Merge remote-tracking branch 'idrinth/the-one' into the-one
marikadeveloper Apr 24, 2024
80662d3
Merge remote-tracking branch 'idrinth/the-one' into the-one
marikadeveloper Apr 24, 2024
db3e356
Merge remote-tracking branch 'idrinth/the-one' into the-one
marikadeveloper Apr 28, 2024
487fccf
Merge branch 'Idrinth:the-one' into the-one
marikadeveloper Apr 28, 2024
08cca9f
Merge branch 'idrinth-api-bench:the-one' into the-one
marikadeveloper May 3, 2024
3c24b5d
Merge branch 'idrinth-api-bench:the-one' into the-one
marikadeveloper May 3, 2024
c4ab080
Merge branch 'the-one' of https://github.com/marikadeveloper/api-benc…
marikadeveloper May 5, 2024
7ad061d
Merge branch 'the-one' of https://github.com/marikadeveloper/api-benc…
marikadeveloper May 6, 2024
87f05c6
Merge branch 'the-one' of https://github.com/marikadeveloper/api-benc…
marikadeveloper May 6, 2024
2c509b7
Merge branch 'the-one' of https://github.com/marikadeveloper/api-benc…
marikadeveloper May 6, 2024
3618c69
refactor(documentation-website): cleanup faq item (#779)
marikadeveloper May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions documentation-website/src/components/faq-item.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,11 @@
list-style-type: none;
width: 100%;

&:focus {
box-shadow: 0 0 2em var(--shadow);
& > button {
width: 100%;
&:focus {
box-shadow: 0 0 2em var(--shadow);
}
}

.accordion-section {
Expand Down
34 changes: 14 additions & 20 deletions documentation-website/src/components/faq-item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,39 +19,33 @@ const FaqItem = ({
setIsOpen(! isOpen,);
};

const handleKeyDown = (e: React.KeyboardEvent<HTMLLIElement>,) => {
if (e.key === 'Enter') {
toggleOpen();
}
};

return (
<li tabIndex={index + ONE} onKeyDown={handleKeyDown} className={'faq-item'}>
<div onClick={() => toggleOpen()} role="button">
<li className={ 'faq-item' }>
<button tabIndex={ index + ONE } onClick={ () => toggleOpen() }>
<div className="accordion-section">
<h2>
{
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-expect-error
<Lang lnkey={`faq.questions.title_${ index + ONE }`} />
<Lang lnkey={ `faq.questions.title_${ index + ONE }` }/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Investigate and resolve TypeScript errors suppressed by @ts-expect-error.

Also applies to: 42-44

}
</h2>
{isOpen ?
{ isOpen ?
<span className="up-arrow"></span>
:
<span className="down-arrow"></span>
}
</div>
</div>
{isOpen &&
<p>
{
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-expect-error
<Lang lnkey={`faq.questions.description_${ index + ONE }`} />
}
</p>
}
{ isOpen &&
<p>
{
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-expect-error
<Lang lnkey={ `faq.questions.description_${ index + ONE }` }/>
}
</p>
}
</button>
</li>
);
};
Expand Down
Loading