Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] fix no code style divergence #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marfanr
Copy link

@marfanr marfanr commented Sep 11, 2024

Jira Link:

Description

Fix code style divergence using a formatter to resolve the Uncrustify test failure in GitHub Actions workflows.

6: No code style divergence in file 'test/geometry/point_2_test.cpp'
6: 
6: No code style divergence in file 'test/geometry/point_3_test.cpp'
6: 
6: No code style divergence in file 'test/matrix/matrix_inverse_test.cpp'
6: 
6: No code style divergence in file 'test/matrix/matrix_test.cpp'
6: 
6: No code style divergence in file 'test/matrix/matrix_transformation_test.cpp'
6: 
6: No code style divergence in file 'test/matrix/vector_test.cpp'
6: 
6: -- run_test.py: return code 1
6: -- run_test.py: verify result file '/home/runner/work/tachimawari/tachimawari/build/keisan/test_results/keisan/uncrustify.xunit.xml'
6/7 Test #6: uncrustify .......................***Failed    0.23 sec

Type of Change

  • Bugfix
  • Enhancement
  • New feature
  • Breaking change (fix or feature that would cause the existing functionality to not work as expected)

How Has This Been Tested?

  • New unit tests added.
  • Manual tested.

Checklist:

  • Using Branch Name Convention
    • feature/JIRA-ID-SHORT-DESCRIPTION if has a JIRA ticket
    • enhancement/SHORT-DESCRIPTION if has/has no JIRA ticket and contain enhancement
    • hotfix/SHORT-DESCRIPTION if the change doesn't need to be tested (urgent)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made the documentation for the corresponding changes.

@marfanr marfanr changed the title Enhancement/fix no code style divergence [Enhancement] fix no code style divergence Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants