Skip to content

Commit

Permalink
Merge pull request #65 from ichiro-its/hotfix/fix-keisan-unit-tests
Browse files Browse the repository at this point in the history
[Sprint 22 / PD-373] - [Hotfix] Fix Keisan Unit Tests
  • Loading branch information
JayantiTA authored Nov 3, 2023
2 parents 0ce3ac2 + 7dd64d0 commit 1b77713
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 10 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,5 @@ jobs:

- name: Build and test workspace
uses: ichiro-its/ros2-build-and-test-action@main
with:
ros2-distro: rolling
1 change: 1 addition & 0 deletions .github/workflows/deploy-debian-nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ jobs:
- name: Build nightly Debian package
uses: ichiro-its/ros2-build-debian-action@main
with:
ros2-distro: rolling
unique-version: true

- name: Deploy nightly Debian package to server
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/deploy-debian-stable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ jobs:

- name: Build stable Debian package
uses: ichiro-its/ros2-build-debian-action@main
with:
ros2-distro: rolling

- name: Deploy stable Debian package to server
uses: appleboy/scp-action@master
Expand Down
8 changes: 4 additions & 4 deletions test/angle/euler_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,9 @@ TEST(EulerTest, AssignmentConstructor)
{ \
ksn::Euler<TYPE> a(SOURCE), b = SOURCE, c; \
c = SOURCE; \
EXPECT_EQ(a, SOURCE); \
EXPECT_EQ(b, SOURCE); \
EXPECT_EQ(c, SOURCE); \
EXPECT_TRUE(a == SOURCE); \
EXPECT_TRUE(b == SOURCE); \
EXPECT_TRUE(c == SOURCE); \
}

ksn::Euler<float> float_euler(90_deg, 90_deg, 90_deg);
Expand Down Expand Up @@ -96,5 +96,5 @@ TEST(EulerTest, QuaternionConversion)

auto quaternion = euler.quaternion();

ASSERT_EQ(quaternion.euler(), euler);
ASSERT_TRUE(quaternion.euler() == euler);
}
6 changes: 3 additions & 3 deletions test/angle/quaternion_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@ TEST(QuaternionTest, AssignmentConstructor)
{ \
ksn::Quaternion<TYPE> a(SOURCE), b = SOURCE, c; \
c = SOURCE; \
EXPECT_EQ(a, SOURCE); \
EXPECT_EQ(b, SOURCE); \
EXPECT_EQ(c, SOURCE); \
EXPECT_TRUE(a == SOURCE); \
EXPECT_TRUE(b == SOURCE); \
EXPECT_TRUE(c == SOURCE); \
}

ksn::Quaternion<float> float_quaternion(1.0f, 1.0f, 1.0f, 1.0f);
Expand Down
4 changes: 1 addition & 3 deletions test/matrix/matrix_inverse_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,7 @@ class MatrixInverseTest : public ::testing::TestWithParam<matrix_3d_inverse_args
}

if (((*matrix) == params.inverse) != params.is_valid) {
return testing::AssertionFailure() << "the result validation is failed\n" <<
"result = " << (*matrix) << "\n" <<
"target = " << params.inverse;
return testing::AssertionFailure() << "the result validation is failed";
}

return testing::AssertionSuccess();
Expand Down

0 comments on commit 1b77713

Please sign in to comment.