Support native PBKDF2 #961
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jasonkatonica FYI |
JinhangZhang
force-pushed
the
supportNativePBKDF2
branch
2 times, most recently
from
8cfeb4b to
a744174
Compare
keithc-ca
requested changes
Mar 6, 2025
closed/src/java.base/share/classes/jdk/crypto/jniprovider/NativeCrypto.java
Show resolved
Hide resolved
closed/src/java.base/share/classes/jdk/crypto/jniprovider/NativeCrypto.java
Outdated
Show resolved
Hide resolved
src/java.base/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java
Outdated
Show resolved
Hide resolved
src/java.base/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java
Outdated
Show resolved
Hide resolved
src/java.base/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java
Outdated
Show resolved
Hide resolved
JinhangZhang
force-pushed
the
supportNativePBKDF2
branch
3 times, most recently
from
abc7b61 to
6522dc8
Compare
keithc-ca
requested changes
Mar 7, 2025
src/java.base/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java
Outdated
Show resolved
Hide resolved
JinhangZhang
force-pushed
the
supportNativePBKDF2
branch
from
6522dc8 to
cf418d1
Compare
JinhangZhang
force-pushed
the
supportNativePBKDF2
branch
2 times, most recently
from
ec2a129 to
e93838f
Compare
A native implementation of the following PBKDF2 related crypto sevices are supported to optimze the PBKDF2 key derivations performance. - PBKDF2WithHmacSHA1 - PBKDF2WithHmacSHA224 - PBKDF2WithHmacSHA256 - PBKDF2WithHmacSHA384 - PBKDF2WithHmacSHA512 - PBKDF2WithHmacSHA512/224 - PBKDF2WithHmacSHA512/256 A new JVM option (jdk.nativePBKDF2) is provided to enable the use of the native PBKDF2 implementation, which is disabled by default. Signed-off-by: Jinhang Zhang <[email protected]>
JinhangZhang
force-pushed
the
supportNativePBKDF2
branch
from
e93838f to
87098db
Compare
keithc-ca
requested changes
Mar 7, 2025
| @@ -3845,3 +3857,89 @@ Java_jdk_crypto_jniprovider_NativeCrypto_XDHGenerateSecret | |||
| } | |||
| return ret; | |||
| } | |||
|
|
|||
| /* Password based key derivation functions | |||
There was a problem hiding this comment.
Typo, missing period:
/* Password based key derivation function.| */ | ||
| JNIEXPORT jbyteArray JNICALL | ||
| Java_jdk_crypto_jniprovider_NativeCrypto_PBKDF2Derive | ||
| (JNIEnv *env, jclass clazz, jbyteArray password, jbyteArray salt, jint iterations, jint keyLength, jint hashAlgorithm) |
There was a problem hiding this comment.
The second parameter is not a class as this function implements a non-static method. Please ensure all signatures are correct and consistently use jclass clazz for static methods and jobject thisObj for non-static methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A native implementation of the following PBKDF2 related crypto sevices are supported to optimze the PBKDF2 key derivations performance.
A new JVM option (
jdk.nativePBKDF2) is provided to enable the use of the native PBKDF2 implementation, which is disabled by default.