Skip to content
This repository has been archived by the owner on Feb 13, 2025. It is now read-only.

Fix metric name #377

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Fix metric name #377

merged 2 commits into from
Oct 23, 2024

Conversation

perkons
Copy link

@perkons perkons commented Nov 10, 2023

Description

Prometheus metric naming best practices not followed for metric name "oracledb_tablespace_free"

Fixes #372

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Renamed the metric in toml file and I am using it in production.

Screenshots (if appropriate):

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes

@iamseth iamseth merged commit 7562579 into iamseth:master Oct 23, 2024
@perkons perkons deleted the fix_metric_name branch October 27, 2024 13:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prometheus metric naming best practices not followed
2 participants