Expand ModelsTree component to accept visibilityHandler as a function #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grigasp
requested changes
Sep 14, 2023
common/changes/@itwin/tree-widget-react/modelsTree_parameter_adjustment_2023-09-13-17-24.json
Outdated
Show resolved
Hide resolved
packages/itwin/tree-widget/src/components/trees/models-tree/ModelsTree.tsx
Outdated
Show resolved
Hide resolved
packages/itwin/tree-widget/src/test/trees/models-tree/ModelsTree.test.tsx
Outdated
Show resolved
Hide resolved
packages/itwin/tree-widget/src/test/trees/models-tree/ModelsTree.test.tsx
Outdated
Show resolved
Hide resolved
packages/itwin/tree-widget/src/test/trees/models-tree/ModelsTree.test.tsx
Outdated
Show resolved
Hide resolved
packages/itwin/tree-widget/src/test/trees/models-tree/ModelsTree.test.tsx
Outdated
Show resolved
Hide resolved
grigasp
requested changes
Sep 14, 2023
packages/itwin/tree-widget/src/test/trees/models-tree/ModelsTree.test.tsx
Outdated
Show resolved
Hide resolved
packages/itwin/tree-widget/src/test/trees/models-tree/ModelsTree.test.tsx
Outdated
Show resolved
Hide resolved
grigasp
approved these changes
Sep 14, 2023
packages/itwin/tree-widget/src/test/trees/models-tree/ModelsTree.test.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand the ModelsTree component to accept
visibilityHandleras a callback which returns avisibilityHandlerobject.With these changes ModelTree creation workflows look like this:
visibilityHandleris passed as an object, we pass it on and use it without taking care of its disposal.visibilityHandleris passed as a function, we call the function which creates the object and take care of its disposal.Also, had to change the way that we are mocking
visibilityHandlerin our ModelTree tests since it was mocking thevisibilityHandleras a function and not as an object, which led to false positives when checking what is the type of thevisibilityHandler.