Added missing useInertPolyfill() calls
#2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r100-stack
requested review from
mayank99 and
smmr-dn
and removed request for
a team
mayank99
reviewed
Sep 6, 2024
mayank99
approved these changes
Sep 6, 2024
smmr-dn
approved these changes
Sep 6, 2024
mayank99
approved these changes
Sep 9, 2024
smmr-dn
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In #2001 (comment), @mayank99 pointed out a missing
useInertPolyfill()inPanels. That made me realize that it was missing inCarouselSlide.tsxtoo.To prevent forgetting to call
useInertPolyfill()in the future, theuseInertPolyfill()is now moved to theThemeProvider(#2224 (comment)).Related: #2001 (comment), #2001 (comment)
Testing
inertis not supported) thatinertis still working as expected inOverlayandCarouselSlide.Docs
Didn't add changeset as we felt there's no need to communicate this small change (#2224 (comment)).