useOverflow argument change: items → itemsCount
#2150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporarily remove unnecessary CI jobs.
r100-stack
changed the title
ButtonGroupOverflowContainer prop change: items → itemsCount
r100-stack
requested review from
mayank99 and
smmr-dn
and removed request for
a team
1 task
smmr-dn
approved these changes
Oct 1, 2024
r100-stack
changed the base branch from
r/useoverflow-new-algorithm
to
r/unit-tests-to-e2e
r100-stack
force-pushed
the
r/overflow-container
branch
from
127b8ff
to
c23cffb
Compare
r100-stack
changed the title
OverflowContainer prop change: items → itemsCountuseOverflow argument change: items → itemsCount
Sounds good, moved it up the stack. Updated the existing message with the new order. |
mayank99
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Pulled out of #2120 as PR 2 in the PR stack (PR stack order). Didn't include this change in #2154 to prevent that PR from getting large and also because of #2150 (review).
In the
OverflowContainerfrom later in the stack, it could be confusing whyitemsare passed aschildrenand as theitemsprop (@mayank99 pointed this out a while back). Thus, this PR renamesuseOverflow()'sitemsargument toitemsCount.Testing
Tests still passing.
Docs
No changeset since not a user facing change.