-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduced ProfileSolidInformationRecord classes. #15
base: master
Are you sure you want to change the base?
Conversation
Added IProfiledSolidDefinition mix-in as source end-point for relationships referencing a Profile.
@diegoalexdiaz have you run the schema inventory job to update the inventory? You will also have to sign the CLA. @naveedkhan8067 schema validation jobs are being skipped on this branch |
Hey, this seems like a "Draft" PR and right now the validation builds only triggered with PR's which are not "Draft" |
You're right. Sorry about that. |
No problem! |
Corrected typeName for TransitionType property.
Is your question about just the property-category name? or the usage of "ProfiledSolidInformationRecord" throughout the schema? If it is the second, we have a decision to make. Class names in BIS schemas tend to replicate the naming introduced in BisCore when there's not a better name already established for a concept in a given domain. The name for the base class from BisCore in this case is "InformationRecord" so those two words have been typically replicated together whenever used. I share your concern of the long names in the schema, so the decision to be made is about deviating from the naming conventions used everywhere else to achieve shorter class names in this particular case (i.e. ProfiledSolidInformationRecord --> ProfiledSolidRecord). Any strong opinions @caseymullen, @ColinKerr and others? |
@@ -366,4 +367,134 @@ | |||
<ECProperty propertyName="Width" typeName="double" description="Extent of the capsule in the direction of the x-axis." category="ProfileProperties" kindOfQuantity="AECU:LENGTH_SHORT" /> | |||
<ECProperty propertyName="Depth" typeName="double" description="Extent of the capsule in the direction of the y-axis." category="ProfileProperties" kindOfQuantity="AECU:LENGTH_SHORT" /> | |||
</ECEntityClass> | |||
|
|||
<ECEntityClass typeName="ProfiledSolidInformationRecordElement" modifier="Abstract" displayLabel="Profiled Solid Information Record Element" description="A bis:InformationRecordElement serving as the base class for implementations capturing data about solids defined from Profiles."> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Markdown was not updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last time we discussed these changes at the BWG, updating documentation was left to your team to address once these new classes and patterns are proved to work for your use-cases.
No description provided.