Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ZeroConf discovery #717

Merged
merged 7 commits into from
Jan 18, 2022

Conversation

egguy
Copy link
Contributor

@egguy egguy commented Jan 18, 2022

Hello,

I've added the support for discovering the overkiz box by ZeroConf.

The entry is: _kizbox._tcp.local.

There's a properties attribute which contain directly the gateway ref (aka gateway_pin).

@iMicknl
Copy link
Owner

iMicknl commented Jan 18, 2022

Thanks! Could you add a test as well? Since core has the requirement for 100% test coverage config flow, we require that for config flow as well.

If you want, you could also see how you can bring this to core yourselves as well. See #697. The config flow in core has some slight changes though.

Copy link
Owner

@iMicknl iMicknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would you like to do a PR to core as well, with this functionality? If you need help setting up core dev environment, I am happy to help.

@iMicknl iMicknl merged commit 4853ea0 into iMicknl:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants