Re-auth prompt on BadCredentialsException #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix Nest Protect integration for Home Assistant looses authentication after home assistant restarts iMicknl#341, where the integration really has to be-authenticate.
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
custom_components/nest_protect/init.py:248
- [nitpick] The error message 'Need to re-authenticate the integration' could be more informative. Consider providing more context, such as 'Bad credentials detected. Please re-authenticate the Nest Protect integration.'
LOGGER.debug("Need to re-authenticate the integration")
custom_components/nest_protect/init.py:247
- Ensure that the new behavior for handling 'BadCredentialsException' and raising 'ConfigEntryAuthFailed' is covered by tests.
except BadCredentialsException as exception:
iMicknl
reviewed
Feb 18, 2025
iMicknl
approved these changes
Feb 18, 2025
iMicknl
reviewed
Feb 18, 2025
iMicknl
reviewed
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix Nest Protect integration for Home Assistant looses authentication after home assistant restarts #341, where the integration really has to be-authenticate.