Reduce timeout for subscription sessions to avoid lost connections #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timeout has been reduced from 3600 x 24 to 600, to operate as a heart beat. The total timeout was too long to handle well lost internet connections. With the reduced timeout, if the HA instance is disconnected from the internet and loose the callback connection, which is not caught by the aiohttp as an exception, the integration will re-initiate a connection as the timeout reached. The limit set to 600, as on previous versions where the integration was failing, it was reconnecting every 300 seconds. It is the double of that for not introducing excessive load on any server.
|
Please excuse me @iMicknl, I have no clue that this should be merged to beta or main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timeout has been reduced from 3600 x 24 to 600, to operate as a heart beat. The total timeout was too long to handle well lost internet connections. With the reduced timeout, if the HA instance is disconnected from the internet and loose the callback connection, which is not caught by the aiohttp as an exception, the integration will re-initiate a connection as the timeout reached.
The limit set to 600, as on previous versions where the integration was failing, it was reconnecting every 300 seconds. It is the double of that for not introducing excessive load on any server.