Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the authentication method to use cookie-based authentication instead of deprecated authentication #279

Merged
merged 48 commits into from
Dec 30, 2024

Conversation

iMicknl
Copy link
Owner

@iMicknl iMicknl commented Dec 13, 2023

This pull request includes several updates and improvements across multiple files, primarily focusing on upgrading dependencies, updating configurations, and enhancing the Nest Protect integration. The most important changes include upgrading the Python version, adding new features to the devcontainer, and updating the authentication method for the Nest Protect integration.

Dependency and Configuration Updates:

  • Upgraded Python version from 3.11 to 3.12 in .devcontainer/devcontainer.json, .github/workflows/pre-commit.yml, and .github/workflows/pytest.yml [1] [2] [3].
  • Updated various dependencies in .pre-commit-config.yaml, including pyupgrade, black, codespell, flake8, isort, and yamllint [1] [2].

Devcontainer Enhancements:

  • Added ffmpeg-apt-get feature and additional packages to the postCreateCommand in .devcontainer/devcontainer.json.

Nest Protect Integration Improvements:

  • Updated the authentication method to use cookie-based authentication instead of API key authentication in custom_components/nest_protect/__init__.py [1] [2].
  • Enhanced the data subscription process and improved error handling in custom_components/nest_protect/__init__.py [1] [2] [3].

Documentation Updates:

  • Updated the README with new image links and additional instructions for retrieving issue_token and cookies for authentication [1] [2] [3].

These changes ensure that the project stays up-to-date with the latest dependencies and improves the overall functionality and reliability of the Nest Protect integration.

@iMicknl iMicknl force-pushed the beta branch 2 times, most recently from 2ed7be0 to 54c98d3 Compare December 16, 2023 23:51
@iMicknl iMicknl changed the title [v2] release [v1] release Dec 17, 2023
iMicknl and others added 5 commits December 17, 2023 12:12
* replace depecated Celsius unit

* use event_loop since loop is deprecated

* empty newline at end of file
* Fix battery level sensor Nest Temperature Sensors

This was regressed as part of 54c98d3

SUPPORTED_KEYS is a dictionary using sensor description key as the "key". Prior to this fix, SUPPORTED_KEYS was always picking up the Nest Protect sensor description and completely ignoring the temperature sensor one.

* Fix code style

* Fix code style
iMicknl and others added 21 commits June 16, 2024 00:39
* update pytest-homeassistant-custom-component to match homeassistant

* update pytest-socket

* update pytest-timeout

* update pytest

* unpin pytest-homeassistant-custom-component
* Fixing PynestException: 200 error while subscribing - #345

First step to fix PynestException: 200 error while subscribing

* Fixing PynestException: 200 error while subscribing - #345

Second step to fix PynestException: 200 error while subscribing

* Fixing PynestException: 200 error while subscribing - #345

Third and final step to fix PynestException: 200 error while subscribing

* Fix linting

---------

Co-authored-by: Mick Vleeshouwer <[email protected]>
My fresh installation of Chrome defaulted to "Block all third-party Cookies in Incognito"

Co-authored-by: Mick Vleeshouwer <[email protected]>
* Add Last Audio Self Test and Last Manual Self Test

Adding two more datetime sensors for test times.

* Add Removed from Base sensor

I have chosen tray-remove as icon, as it looks similar to the protect being removed.
* Trying to fix Errors in _async_subscribe_for_data #347

This would fix the issue with objects and then wraps it with Bucket as expected by the pynest client, but if it is still generating high traffic on Google servers, then there is a flaw somewhere in the main logic of subscription process, and it re-subscribes again and again with the pynest client, which I cannot really test, as I have only battery powered nest protects, so there isn't live motion detection.

* Trying to fix Errors in _async_subscribe_for_data #347 

Also needed to fix the aforementioned issue as wrapping with Bucket fails on the WhereBucketValue otherwise.

* Fix for lint

* Another fix for lint
@iMicknl iMicknl marked this pull request as ready for review December 30, 2024 11:13
@iMicknl iMicknl changed the title [v1] release Update the authentication method to use cookie-based authentication instead of deprecated authentication Dec 30, 2024
@iMicknl iMicknl merged commit 8054aa2 into main Dec 30, 2024
2 of 3 checks passed
@iMicknl iMicknl deleted the beta branch December 30, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants