core: Add null activeWorkspace check in moveWorkspaceToMonitor #9503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
After I turn all monitors off with DPMS and then turn them back on, Hyprland would sometimes crash. I looked at a core dump and it seems to be just a missing null check (this backtrace is from Hyprland v0.47.2, it's from a release build with debug symbols):
As you can see from the backtrace, the new monitor's setupDefaultWS calls moveWorkspaceToMonitor but there isn't an active workspace of the monitor at that point.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
I'm not sure on the exact conditions to replicate this issue so I'm not 100% sure it fully fixes the issue, but it definitely adds a needed null check where there wasn't one before.
Is it ready for merging, or does it need work?
Ready for merging