Support wp color management proto #9444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks as always! tag me for review when this is ready. |
|
@vaxerski ready for review |
vaxerski
reviewed
Feb 23, 2025
vaxerski
approved these changes
Feb 26, 2025
|
stellar work as always |
|
Truly Fast and active development |
zjeffer
reviewed
Feb 26, 2025
| @@ -12,6 +12,7 @@ | |||
| #include "Timer.hpp" | |||
| #include "math/Math.hpp" | |||
| #include <optional> | |||
| #include "protocols/types/ColorManagement.hpp" | |||
There was a problem hiding this comment.
this include is wrong, should be "../protocols/types/ColorManagement.hpp"
causes build failure for plugins: Duckonaut/split-monitor-workspaces#166
There was a problem hiding this comment.
auto-import set me up %)
There was a problem hiding this comment.
Not really your fault though, preferably this would get picked up by the CI/CD and/or enforced through things like clang-tidy/clang-format/cppcheck
There was a problem hiding this comment.
auto-import set me up %)
what auto import are you using 😭 i didn't even know that was a thing for c++
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Support wp color-management. #9443
Added
debug:full_cm_prototo switch proto into debug mode (requires restart).In regular mode this implementation does almost nothing. It handles the minimum required subset of features.
In debug mode all features and values are marked as supported. Features related to fullscreen HDR will work the same as with xx-cm and frog-cm. Other features will only store and pass values and output some log messages.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Needs #9064 to be useful. Without it xx-cm and frog-cm should be used instead because those protos are less likely to break things for newer clients with correct wp-cm support.
Needs nix wp version bump.
Needs a proper way of handling images description ids to avoid duplication (not a priority, very unlikely conditions to be useful)
Is it ready for merging, or does it need work?
Ready.