Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(render): enforce framebuffer offloading and remove introspection toggle #9217

Merged
merged 1 commit into from
Jan 31, 2025
Merged

perf(render): enforce framebuffer offloading and remove introspection toggle #9217

merged 1 commit into from
Jan 31, 2025
+10 −153

Conversation

nnyyxxxx
Copy link
Contributor

fixes #9172

vaxerski
vaxerski reviewed Jan 29, 2025
View reviewed changes
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove much more codepaths in this MR

@nnyyxxxx nnyyxxxx marked this pull request as draft January 29, 2025 10:43
@nnyyxxxx nnyyxxxx requested a review from vaxerski January 29, 2025 10:56
@nnyyxxxx nnyyxxxx marked this pull request as ready for review January 29, 2025 10:58
@nnyyxxxx
Copy link
Contributor Author

oops..

@nnyyxxxx nnyyxxxx marked this pull request as draft January 29, 2025 11:10
@nnyyxxxx
Copy link
Contributor Author

nvm

@nnyyxxxx nnyyxxxx marked this pull request as ready for review January 29, 2025 11:12
@nnyyxxxx
Copy link
Contributor Author

you can remove much more codepaths in this MR

bro did me dirty, 3 minutes after i opened the pull request... 😭 should have opened as a draft...

@nnyyxxxx
perf(render): enforce framebuffer offloading and remove introspection…
e06bcc7 
… toggle

refactor(render): remove redundant introspection code paths
@nnyyxxxx nnyyxxxx changed the title perf(render): remove force_introspection config option, enable by default perf(render): enforce framebuffer offloading and remove introspection toggle Jan 29, 2025
@nnyyxxxx
Copy link
Contributor Author

nnyyxxxx commented Jan 29, 2025 •
edited
Loading

do we want RequiresIntrospection?, The minimal performance benefit we gain from the added complexity doesn't make it worth it IMO

@vaxerski
Copy link
Member

RequiresIntrospection

no

@nnyyxxxx
Copy link
Contributor Author

any reason why this is being held off? @vaxerski

@vaxerski
Copy link
Member

yes, I am not a robot, and I cant review everything in 2s

@vaxerski vaxerski merged commit ddf180f into hyprwm:main Jan 31, 2025
12 checks passed
@vaxerski vaxerski mentioned this pull request Jan 31, 2025
Open
@nnyyxxxx nnyyxxxx deleted the patch branch January 31, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaxerski vaxerski vaxerski approved these changes

Assignees
No one assigned
Labels
config core render
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows flickering since the 465cf66 commit
2 participants
@nnyyxxxx @vaxerski