CMake build improvements #1167
Open
CMake build improvements #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocm 6 seems to return this type for host memory allocated outside of rocm
- Get rid of HYPRE_INSTALL_PREFIX, use CMAKE_INSTALL_PREFIX only. This follows cmake common practices and allows changing the install prefix in a single place. - Get rid of HYPRE_BUILD_TYPE, use CMAKE_BUILD_TYPE only. This follows cmake common practices and allows changing the build type in a single place. - Ensure that certain internal cache flags are toggled on/off as needed. These probably shouldn't be cached at all, however I left them cached. Specifically this ensures that HYPRE_USING_DEVICE_MEMORY and HYPRE_USING_DEVICE_MEMORY cannot be simultaneously enabled.
|
There's also the conventional (and built in!) |
|
Hi Andrew, thank you for the contribution! I included this on #1181 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made it easier and less error prone to change configurations in CMake.
follows cmake common practices and allows changing the install prefix
in a single place.
follows cmake common practices and allows changing the build type
in a single place.
needed. These probably shouldn't be cached at all, however I left them
cached. Specifically this ensures that HYPRE_USING_DEVICE_MEMORY and
HYPRE_USING_DEVICE_MEMORY cannot be simultaneously enabled.