[FIX] #1245 DIDExchange request handling should require invitation key rotation #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lli <[email protected]>
Signed-off-by: lli <[email protected]>
Signed-off-by: lli <[email protected]>
Signed-off-by: lli <[email protected]>
Signed-off-by: lli <[email protected]>
Signed-off-by: lli <[email protected]>
JamesKEbert
previously approved these changes
Aug 1, 2024
gmulhearn
reviewed
Aug 1, 2024
Signed-off-by: lli <[email protected]>
lukewli-anonyome
dismissed stale reviews from gmulhearn and JamesKEbert
via
91d5865
JamesKEbert
approved these changes
Aug 1, 2024
alberto-instnt
pushed a commit
to instnt-inc/instnt-aries-vcx
that referenced
this pull request
Sep 10, 2024
…vitation key rotation (hyperledger#1278) * Require Inviter Key and Store in HarnessAgent Signed-off-by: lli <[email protected]> * Minor Clippy/Test fixes Signed-off-by: lli <[email protected]> * Clippy Signed-off-by: lli <[email protected]> * Clippy Signed-off-by: lli <[email protected]> * change anon unpacks to return rec_vk Signed-off-by: lli <[email protected]> * clippy Signed-off-by: lli <[email protected]> * Remove TODO comments Signed-off-by: lli <[email protected]> --------- Signed-off-by: lli <[email protected]>
alberto-instnt
pushed a commit
to instnt-inc/instnt-aries-vcx
that referenced
this pull request
Sep 10, 2024
…vitation key rotation (hyperledger#1278) * Require Inviter Key and Store in HarnessAgent Signed-off-by: lli <[email protected]> * Minor Clippy/Test fixes Signed-off-by: lli <[email protected]> * Clippy Signed-off-by: lli <[email protected]> * Clippy Signed-off-by: lli <[email protected]> * change anon unpacks to return rec_vk Signed-off-by: lli <[email protected]> * clippy Signed-off-by: lli <[email protected]> * Remove TODO comments Signed-off-by: lli <[email protected]> --------- Signed-off-by: lli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a fix for the optional invitation key in DIDExchange handle_request described here in issue https://github.com/hyperledger/aries-vcx/issues/1245.
Closes #1245