-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate connections protocol to a plugin #925
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Daniel Bluhm <[email protected]>
A corresponding PR will be opened to ACA-Py to remove the connections protocol. |
Functionality lost by moving connections protocol to a plugin (e.g. things we may wish to reinstate as a feature of this plugin, if there's enough desire for it):
Things currently broken as a result of moving to a plugin (e.g. things we must fix to merge and have "good enough" feature parity):
|
Corresponding PR in ACA-Py: hyperledger/aries-cloudagent-python#3184 |
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
This plugin is dependent on changes in an unreleased version of ACA-Py but is otherwise ready for review. |
This PR lifts the connections protocol out of ACA-Py proper and turns it into a plugin. The connections protocol has been deprecated for several releases. This completes the deprecation period while also encouraging the community to move on to bigger and better things (DID Exchange). But, for those who absolutely cannot move on, this plugin will fill the gap.
This is the first instance of a deprecated protocol entering retirement as a plugin. There may be processes to figure out still but I think it's time to make the jump.
Opening as draft while testing for input and thoughts.
cc @swcurran @jamshale