Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate connections protocol to a plugin #925

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

dbluhm
Copy link
Member

@dbluhm dbluhm commented Aug 19, 2024

This PR lifts the connections protocol out of ACA-Py proper and turns it into a plugin. The connections protocol has been deprecated for several releases. This completes the deprecation period while also encouraging the community to move on to bigger and better things (DID Exchange). But, for those who absolutely cannot move on, this plugin will fill the gap.

This is the first instance of a deprecated protocol entering retirement as a plugin. There may be processes to figure out still but I think it's time to make the jump.

Opening as draft while testing for input and thoughts.

cc @swcurran @jamshale

@dbluhm
Copy link
Member Author

dbluhm commented Aug 19, 2024

A corresponding PR will be opened to ACA-Py to remove the connections protocol.

@dbluhm
Copy link
Member Author

dbluhm commented Aug 19, 2024

Functionality lost by moving connections protocol to a plugin (e.g. things we may wish to reinstate as a feature of this plugin, if there's enough desire for it):

  • Automatic mediator setup on startup using a connections invitation
  • Automatic endorser setup on startup using a connections invitation

Things currently broken as a result of moving to a plugin (e.g. things we must fix to merge and have "good enough" feature parity):

  • _fetch_connection_targets_for_invitation needs to be reworked or extended by plugin to support conn invite; consider mapping connections invitation into InvitationMessage for uniform handling.
  • invitation attachment and retrieval; consider storing and retrieving using interface other than conn record
  • request attachment and retrieval; consider storing and retrieving using interface other than conn record
  • OOB Manager _perform_handshake

@dbluhm
Copy link
Member Author

dbluhm commented Aug 19, 2024

Corresponding PR in ACA-Py: hyperledger/aries-cloudagent-python#3184

@dbluhm
Copy link
Member Author

dbluhm commented Sep 19, 2024

This plugin is dependent on changes in an unreleased version of ACA-Py but is otherwise ready for review.

@dbluhm dbluhm marked this pull request as ready for review September 19, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant