Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ENS CCIP Read improvements #2164

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Syn-McJ
Copy link

@Syn-McJ Syn-McJ commented Mar 12, 2025

What does this PR do?

The current implementation of ERC-3668: CCIP Read for ENS name resolution is too strict and doesn't follow the standard exactly.

  • Currently, the {sender} parameter is enforced in URL while the standard specifies that it can be sent in POST as part of DTO.
  • Currently, the callback request is always made to the hard-coded resolveWithProof method while the standard specifies that the callbackFunction from OffchainLookup should be used.
  • Data in the isEIP3668 method might have double quotes that must be stripped.

Where should the reviewer start?

The ERC-3668: https://eips.ethereum.org/EIPS/eip-3668#abstract

Why is it needed?

These problems prevent L2 subdomains created with Durin from being resolved, as well as others like base.eth subdomains.

Checklist

  • I've read the contribution guidelines.
  • I've added tests (if applicable).
  • I've added a changelog entry if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant