Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(satp): review update closes #3752 #3814

Open
wants to merge 1 commit into
base: satp-dev
Choose a base branch
from
Open

feat(satp): review update closes #3752 #3814

wants to merge 1 commit into from

Conversation

pandaio22
Copy link

@pandaio22 pandaio22 commented Mar 18, 2025 •
edited
Loading

Added:

  • packages/cactus-plugin-satp-hermes/docs/review/issue-3752/INCONSISTENCIES.md
  • packages/cactus-plugin-satp-hermes/docs/review/issue-3752/2025-03-STAGE-0-Requirements.png
  • packages/cactus-plugin-satp-hermes/docs/review/issue-3752/2025-03-STAGE-1-Requirements.png

RafaelAPB
RafaelAPB requested changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@RafaelAPB RafaelAPB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please change the structure and fix the DCO

@pandaio22 pandaio22 force-pushed the current-satp-sev-pandaio22 branch 3 times, most recently from dcc7cc5 to c6046b6 Compare March 20, 2025 11:37
@pandaio22 pandaio22 changed the title feat(satp): Detect inconsistencies between SATP code and draft (Stage 0 and Stage 1 inconsistencies) - Closes #3752 feat(satp): review update closes #3752 Mar 20, 2025
@pandaio22 pandaio22 changed the title feat(satp): review update closes #3752 feat(satp): review update-closes #3752 Mar 20, 2025
@pandaio22 pandaio22 changed the title feat(satp): review update-closes #3752 feat(satp): review update closes #3752 Mar 20, 2025
@pandaio22 pandaio22 force-pushed the current-satp-sev-pandaio22 branch from c6046b6 to d4dac27 Compare March 21, 2025 11:04
@pandaio22 pandaio22 force-pushed the current-satp-sev-pandaio22 branch 14 times, most recently from b2ba8ae to dd24677 Compare March 21, 2025 12:24
@pandaio22 pandaio22 force-pushed the current-satp-sev-pandaio22 branch 5 times, most recently from 74f1bc6 to 12f9a1c Compare March 21, 2025 12:46
@pandaio22
Copy link
Author

pandaio22 commented Mar 21, 2025 •
edited
Loading

CI - SATP-Hermes Gateway:

  • Noticed an issue regarding the installation of 'foundryup'
  • After troubleshooting, the problem was with the foundry binaries location. The binaries are placed in a different folder than the onde being added to PATH.
  • This is fixed by adding the 'preinstall' script to package.json and extra configuration steps to ci.sh.

This fixes the issue with foundry, allowing build to execute successfully. However, the CI still fails before executing the tests:
image

@pandaio22
feat(satp): review update closes hyperledger-cacti#3752
7e05175 
Signed-off-by: Rodolfo Carapau <[email protected]>

feat(satp): review update closes hyperledger-cacti#3752

Signed-off-by: Rodolfo Carapau <[email protected]>

feat(satp): review update closes hyperledger-cacti#3752

Signed-off-by: Rodolfo Carapau <[email protected]>

feat(satp): review update closes hyperledger-cacti#3752

Signed-off-by: Rodolfo Carapau <[email protected]>

feat(satp): review update closes hyperledger-cacti#3752

Signed-off-by: Rodolfo Carapau <[email protected]>

feat(satp): review update closes hyperledger-cacti#3752

Signed-off-by: Rodolfo Carapau <[email protected]>

feat(satp): review update closes hyperledger-cacti#3752

Signed-off-by: Rodolfo Carapau <[email protected]>

feat(satp): review update closes hyperledger-cacti#3752

Signed-off-by: Rodolfo Carapau <[email protected]>

feat(satp): review update closes hyperledger-cacti#3752

Signed-off-by: Rodolfo Carapau <[email protected]>

feat(satp): review update closes hyperledger-cacti#3752

Signed-off-by: Rodolfo Carapau <[email protected]>

feat(satp): review update closes hyperledger-cacti#3752

Signed-off-by: Rodolfo Carapau <[email protected]>

feat(satp): review update closes hyperledger-cacti#3752

Signed-off-by: Rodolfo Carapau <[email protected]>

feat(satp): review update closes hyperledger-cacti#3752

Signed-off-by: Rodolfo Carapau <[email protected]>

feat(satp): review update closes hyperledger-cacti#3752

Signed-off-by: Rodolfo Carapau <[email protected]>

feat(satp): review update closes hyperledger-cacti#3752

Signed-off-by: Rodolfo Carapau <[email protected]>

feat(satp): review update closes hyperledger-cacti#3752

Signed-off-by: Rodolfo Carapau <[email protected]>

feat(satp): review update closes hyperledger-cacti#3752

Signed-off-by: Rodolfo Carapau <[email protected]>

feat(satp): review update closes hyperledger-cacti#3752

Signed-off-by: Rodolfo Carapau <[email protected]>

feat(satp): review update closes hyperledger-cacti#3752

Signed-off-by: Rodolfo Carapau <[email protected]>

feat(satp): review update closes hyperledger-cacti#3752

Signed-off-by: Rodolfo Carapau <[email protected]>

feat(satp): review update closes hyperledger-cacti#3752

Signed-off-by: Rodolfo Carapau <[email protected]>

feat(satp): review update closes hyperledger-cacti#3752

Signed-off-by: Rodolfo Carapau <[email protected]>
@pandaio22 pandaio22 force-pushed the current-satp-sev-pandaio22 branch from 12f9a1c to 7e05175 Compare March 21, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelAPB RafaelAPB RafaelAPB requested changes

@AndreAugusto11 AndreAugusto11 Awaiting requested review from AndreAugusto11 AndreAugusto11 is a code owner

@petermetz petermetz Awaiting requested review from petermetz petermetz is a code owner

@takeutak takeutak Awaiting requested review from takeutak takeutak is a code owner

@izuru0 izuru0 Awaiting requested review from izuru0 izuru0 is a code owner

@jagpreetsinghsasan jagpreetsinghsasan Awaiting requested review from jagpreetsinghsasan jagpreetsinghsasan is a code owner

@VRamakrishna VRamakrishna Awaiting requested review from VRamakrishna VRamakrishna is a code owner

@sandeepnRES sandeepnRES Awaiting requested review from sandeepnRES sandeepnRES is a code owner

@outSH outSH Awaiting requested review from outSH outSH is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pandaio22 @RafaelAPB