Backport to_bytes performance optimizations #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtimush
force-pushed
the
backport-has-remaining
branch
from
2724137
to
758d3e8
Compare
rtimush
changed the title
rtimush
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #94 and #112.
We had some performance issues and found out that
to_bytes()has a quadratic complexity with respect to the number of chunks in the BufList (in our case it was taking 10 minutes to runto_byteson a ~65MB body). This has been already fixed in1.x, but0.4.xseems to be still widely used, so it would be nice to have this fix there as well.