util: add a channel body #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
previously approved these changes
Nov 20, 2023
|
|
||
| impl<D, E> Sender<D, E> { | ||
| /// Send a frame on the channel. | ||
| pub async fn send(&self, frame: Frame<D>) -> Result<(), SendError> { |
There was a problem hiding this comment.
Even though it's not required internally, should we make these all &mut self?
| /// A body backed by a channel. | ||
| pub struct Channel<D, E = std::convert::Infallible> { | ||
| rx_frame: mpsc::Receiver<Frame<D>>, | ||
| rx_error: mpsc::Receiver<E>, |
There was a problem hiding this comment.
Would a oneshot channel work? It should be a smaller struct, and use less memory wen sending the error (the mpsc channel reserves blocks).
There was a problem hiding this comment.
At first I thought it wouldn't be possible because one shot::Receiver doesn't have a poll_recv method but I suppose I can call Future::poll instead 🤔 I'll try that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new body type that's backed by a
tokio::sync::mpscchannel. Inspired by hyper's oldBody::channel.