Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the ball rolling, since community feedback is desired.
As of now, just download deps and add code. Entrypoint calls main
run
command and, if no further command line args are provided, defaults to starting a daemon (in foreground as per Docker requirement). I'm not a NodeJS developer, so feedback is much appreciated.Add Dockerfile to enable image building.
Using the official NodeJS image, latest LTS tag. More info at https://hub.docker.com/_/node/
Note: Readme states that there is an issue preventing NodeJS 14 from working, but the issue is closed. I went for latest LTS (
1412 as per NodeJS Docker Hub page). Maybe the readme notice is no longer valid?Build:
Run:
FYI, there's a still quicker to test, already built image on my Docker Hub. Test it by running:
Using
--rm
instead of-d
makes the container not go background and it to be deleted after stop. Should stop byCTRL+C
'ing it.FUSE packages and OS support is still not present, but it is feasible under Docker. I guess it's the next thing to add, but merging can provide a base image (with hopefully an Automated Build) in the meantime for others to base on and contribute and improve further. But that can be dealt with in different issues later.