Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: try to stabilize eventer tests #1066

Merged
merged 1 commit into from
Feb 13, 2024
Merged

test: try to stabilize eventer tests #1066

merged 1 commit into from
Feb 13, 2024

Conversation

gen2thomas
Copy link
Collaborator

@gen2thomas gen2thomas commented Feb 13, 2024 •
edited
Loading

Solved issues and/or description of the change

"TestEventerOn" fails sporadically. This change try to stabilize by adding a wait before the event will be fired. Additionally all "t.Errorf" usages are replaced by "require.Fail".

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • New and existing unit tests pass locally with my changes (e.g. by run make test_race)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code

@gen2thomas gen2thomas marked this pull request as ready for review February 13, 2024 09:33
@gen2thomas gen2thomas merged commit 026fd03 into hybridgroup:dev Feb 13, 2024
3 checks passed
@gen2thomas gen2thomas deleted the fix/test_stability branch February 13, 2024 09:33
szampardi pushed a commit to szampardi/gobot that referenced this pull request Nov 4, 2024
@gen2thomas @nexus166
test: try to stabilize eventer tests (hybridgroup#1066)
8f1afdb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gen2thomas