Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change GPUS to GPUs #36945

Merged
merged 2 commits into from
Mar 25, 2025
Merged

Conversation

zhanluxianshen
Copy link
Contributor

@zhanluxianshen zhanluxianshen commented Mar 25, 2025

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers.

@github-actions github-actions bot marked this pull request as draft March 25, 2025 01:11
@zhanluxianshen zhanluxianshen marked this pull request as ready for review March 25, 2025 01:11
@github-actions github-actions bot requested review from stevhliu and ydshieh March 25, 2025 01:11
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

But maybe a review from @stevhliu would be perfect 🙏

Signed-off-by: zhanluxianshen <[email protected]>
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ydshieh ydshieh merged commit ebd2029 into huggingface:main Mar 25, 2025
8 checks passed
@zhanluxianshen zhanluxianshen deleted the change-gpus-to-GPUs branch March 25, 2025 21:25
@zhanluxianshen
Copy link
Contributor Author

Thanks for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants