Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3/N] Use pyupgrade --py39-plus to improve code #36936

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cyyever
Copy link
Contributor

@cyyever cyyever commented Mar 24, 2025

What does this PR do?

Continued work to adopt Python 3.9 syntax. Follows #36857 .

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@github-actions github-actions bot marked this pull request as draft March 24, 2025 16:09
Copy link

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers.

@cyyever cyyever force-pushed the pyupdate39_7 branch 3 times, most recently from 439131a to 4a8ed1d Compare March 24, 2025 16:16
Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with one comment!

@cyyever cyyever marked this pull request as ready for review March 25, 2025 00:44
@Rocketknight1
Copy link
Member

Sorry about the failing tests - try rerunning / updating until they pass, then ping me to merge it!

@cyyever
Copy link
Contributor Author

cyyever commented Mar 26, 2025

Without TF jobs, hope it becomes green.

@cyyever cyyever force-pushed the pyupdate39_7 branch 3 times, most recently from f5d8c37 to 4475a8a Compare March 27, 2025 10:09
@Rocketknight1
Copy link
Member

Hi @cyyever, is this redundant with #37039? Should we close this one and use #37039 instead?

@cyyever
Copy link
Contributor Author

cyyever commented Mar 27, 2025

@Rocketknight1 Can

@cyyever cyyever closed this Mar 27, 2025
@cyyever cyyever deleted the pyupdate39_7 branch March 27, 2025 14:59
@cyyever cyyever restored the pyupdate39_7 branch March 27, 2025 15:00
@cyyever cyyever reopened this Mar 27, 2025
@github-actions github-actions bot marked this pull request as draft March 27, 2025 15:00
Copy link

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@cyyever cyyever force-pushed the pyupdate39_7 branch 6 times, most recently from cd588b3 to af031dc Compare March 27, 2025 15:26
@cyyever cyyever marked this pull request as ready for review March 27, 2025 15:27
@cyyever
Copy link
Contributor Author

cyyever commented Mar 27, 2025

@Rocketknight1 Base on others' opinions, it's better to deal with smaller PRs like this one.

@Rocketknight1
Copy link
Member

@cyyever sure! In that case, please try make fixup and/or rebasing/merging to get the tests to pass, as usual, and then ping me when you're ready to merge.

@cyyever
Copy link
Contributor Author

cyyever commented Mar 27, 2025

@Rocketknight1 Unrelated failures. We can wait them become green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants