Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qwen2-audio] remove default template #36919

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zucchini-nlp
Copy link
Member

What does this PR do?

As per title, blocked by PR on hub model repo, which adds chat template in chat_template.json

Copy link

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the Ready for review button (at the bottom of the PR page).

@github-actions github-actions bot marked this pull request as draft March 24, 2025 09:35
@zucchini-nlp zucchini-nlp marked this pull request as ready for review March 24, 2025 09:50
@zucchini-nlp zucchini-nlp requested a review from qubvel March 24, 2025 09:50
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@qubvel qubvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, the idea is to load it from the Hub instead of having it in the library, right? the only breaking might be if the model revision is fixed somewhere.. but probably super-rare case.

P.S. don't forget to trigger tests before merge

@zucchini-nlp
Copy link
Member Author

Yes, storing template in code was deprecated long ago but for some reason qwen2-audio didn't get its update on time. Not much blocking, just cleaning up so no-one copies bad patterns when adding new models

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants