Skip to content

DeepSpeed tensor parallel+ZeRO #36825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 20, 2025
Merged

Conversation

inkcherry
Copy link
Contributor

@inkcherry inkcherry commented Mar 19, 2025

move from #36114 , Initialization for DeepSpeed tensor parallel+ZeRO optimizer for 2d training, cc @muellerzr

The original PR workflow seems to have encountered some issues and cannot be resolved by refreshing.

@github-actions github-actions bot marked this pull request as draft March 19, 2025 14:41
Copy link

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the Ready for review button (at the bottom of the PR page).

@inkcherry inkcherry marked this pull request as ready for review March 19, 2025 14:42
@ArthurZucker ArthurZucker requested a review from muellerzr March 20, 2025 09:39
@ArthurZucker
Copy link
Collaborator

LGTM but more for @muellerzr

@ArthurZucker ArthurZucker removed their request for review March 20, 2025 09:40
Copy link
Contributor

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@muellerzr muellerzr requested a review from ArthurZucker March 20, 2025 14:13
@ArthurZucker ArthurZucker merged commit 730d2a5 into huggingface:main Mar 20, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants