-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding verbal-reasoning-challenge as a Community Task #551
Open
aryawu0513
wants to merge
1
commit into
huggingface:main
Choose a base branch
from
aryawu0513:verbal-reasoning-challenge-branch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,131 @@ | ||
# MIT License | ||
|
||
# Copyright (c) 2024 The HuggingFace Team | ||
|
||
# Permission is hereby granted, free of charge, to any person obtaining a copy | ||
# of this software and associated documentation files (the "Software"), to deal | ||
# in the Software without restriction, including without limitation the rights | ||
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
# copies of the Software, and to permit persons to whom the Software is | ||
# furnished to do so, subject to the following conditions: | ||
|
||
# The above copyright notice and this permission notice shall be included in all | ||
# copies or substantial portions of the Software. | ||
|
||
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
# SOFTWARE. | ||
|
||
# ruff: noqa: F405, F403, F401 | ||
""" | ||
Task to evaluate LLMs on the verbal reasoning challenge dataset: | ||
https://huggingface.co/datasets/nuprl/verbal-reasoning-challenge | ||
|
||
""" | ||
|
||
import re | ||
from typing import List | ||
|
||
import numpy as np | ||
from aenum import extend_enum | ||
|
||
from lighteval.metrics.metrics import Metrics, SampleLevelMetric | ||
from lighteval.metrics.utils.metric_utils import MetricCategory, MetricUseCase | ||
from lighteval.tasks.lighteval_task import LightevalTaskConfig | ||
from lighteval.tasks.requests import Doc | ||
|
||
|
||
def verbal_prompt_fn(line, task_name: str = None): | ||
return Doc( | ||
task_name=task_name, | ||
query=line["challenge"], | ||
choices=[line["answer"]], | ||
gold_index=0, | ||
specific={"ID": line["ID"]}, | ||
) | ||
|
||
|
||
def _parse_answer(text: str) -> List[List[str]]: | ||
""" | ||
Converts text to lowercase. Then interprets ";" as a separator between | ||
alternatives. Within each alternative, interprets "," and "-->" as separators | ||
for elements of a set. Within each set, drops all non-alphanumeric characters | ||
and returns that set. | ||
|
||
Another way to describe this is that we interpret adjacent words as | ||
phrases that must be present literally. However, comma and arrow separate | ||
distinct phrases that may be present in any order. All other characters | ||
are dropped. | ||
""" | ||
text = text.lower() | ||
alternatives = re.split(r";", text) | ||
result = [] | ||
for alternative in alternatives: | ||
groups = re.split(r"–?-?-?>|,", alternative) | ||
result.append([" ".join(re.findall(r"\b\w+\b", group)) for group in groups]) | ||
return result | ||
|
||
|
||
def _answer_without_thoughts(completion: str) -> str: | ||
if "<think>" not in completion[:200]: | ||
return completion | ||
|
||
chunks = completion.split("</think>") | ||
if len(chunks) <= 1: | ||
return "" | ||
|
||
return chunks[-1].strip() | ||
|
||
|
||
def _check_answer(completion: str, answer: str) -> bool: | ||
""" | ||
Check that all the phrases that must appear in the answer appear in the | ||
completion. We ignore "thoughts", capitalization, and punctuation. | ||
""" | ||
completion = _answer_without_thoughts(completion).lower() | ||
completion = re.sub(r"[^\w\s]", " ", completion) | ||
completion = re.sub(r"\s+", " ", completion) | ||
alternative_answers = _parse_answer(answer) | ||
for answer_phrases in alternative_answers: | ||
if all(re.search(rf"\b{re.escape(phrase)}\b", completion) for phrase in answer_phrases): | ||
return True | ||
return False | ||
|
||
|
||
def verbal_metric(predictions: list[str], formatted_doc: Doc, **kwargs) -> bool: | ||
completion = predictions[0] | ||
answer = formatted_doc.choices[formatted_doc.gold_index] | ||
return _check_answer(completion, answer) | ||
|
||
|
||
verbal_custom_metric = SampleLevelMetric( | ||
metric_name="Verbal_Metric", | ||
higher_is_better=True, | ||
category=MetricCategory.GENERATIVE, | ||
use_case=MetricUseCase.ACCURACY, | ||
sample_level_fn=verbal_metric, | ||
corpus_level_fn=np.mean, | ||
) | ||
|
||
|
||
task = LightevalTaskConfig( | ||
name="verbal_reasoning_challenge", | ||
prompt_function=verbal_prompt_fn, | ||
suite=["community"], | ||
hf_repo="nuprl/verbal-reasoning-challenge", | ||
hf_subset="default", | ||
hf_avail_splits=["test"], | ||
evaluation_splits=["test"], | ||
few_shots_split=None, | ||
few_shots_select=None, | ||
generation_size=2048, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I assume this can be changed? Very low for a reasoning model. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This can be changed at runtime when using vllm or litellm models yes ! |
||
metric=[verbal_custom_metric], | ||
) | ||
|
||
TASKS_TABLE = [task] | ||
|
||
extend_enum(Metrics, "verbal_custom_metric", verbal_custom_metric) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why check the first 200 characters only ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are discussing this. Our expectation is that the
<think>
token should come early -- ideally immediately after the prompt. There are three cases:<think>
tags. We find that Gemini Thinking sometimes does not produce reasoning tokens even when ask for them. So, if we don't find<think>
, we just return the whole response.<think>
but no</think>
: model is stuck "thinking forever" so we return""
below.<think>
and</think>
: we just return the text after</think>
. This is the normal case.