-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add message listening system #4
Add message listening system #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Thanks so much for looking into this, I've been meaning to investigate this for a while so this is super helpful.
A few comments here about the details but in general this looks great.
I've now published dbus-native too, so you can update that here whenever you're ready. By the way, in case you're not aware, HTTP Toolkit Pro is totally free for all contributors to the every repo in this org, and this is already a very helpful contribution already! I've just set you up an account linked to your git email |
Thank you very much I will definitely look into it :) |
@pimterry Interesting how the CI fails on a different test every time. Could you take a look at the code? I applied the requested changes. |
Yeah, I'm not sure what's happening there. There's definitely been some occasional flakiness in the past, but this seems very unusual. I'm going to do some more testing and see if I can get that fixed. |
91845e1
to
3b048c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've now fixed the tests on main and the seem to be much more reliable. I've rebased the PR and it's all passing 👍
Thanks for those quick changes on this @Patrick-van-Halm! I've added a last couple of tiny comments here, but then I think this will be ready to merge.
@pimterry I have made changes as requested, most where just some oversights thanks for letting me know. |
Awesome! Thanks for all the hard work here, this is great 👍. I'll do a release in just a sec. |
Adds the system to listen to Frida agent messages. Requires pull request: Publicize setMethodCallHandler
Resolves: #3