don't send 100-continue until the body has been read from #139
+174
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbr
force-pushed
the
validate-before-continue
branch
from
6f9b757 to
b01d8f4
Compare
jbr
force-pushed
the
validate-before-continue
branch
from
b01d8f4 to
adf1604
Compare
yoshuawuyts
approved these changes
Sep 4, 2020
src/server/decode.rs
Outdated
| @@ -86,11 +88,24 @@ where | |||
| "Unexpected Content-Length header" | |||
| ); | |||
|
|
|||
| let (sender, receiver) = sync::channel(1); | |||
There was a problem hiding this comment.
With regards to #137, using async-channel may actually be better here.
There was a problem hiding this comment.
I'm not sure how much that pr/issue actually matters because async-h1 depends on http-types, which also uses unstable
Co-authored-by: Yoshua Wuyts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #135. if a client says it expects 100-continue and we never read the body, we never send 100 continue and the client will have the option not to send a body.
this is implemented using a
ReadNotifierwhich forwards BufRead and Read and sends a message on an async channel on first read. a task is spawned for each request which awaits that message and sends 100-continue.the approach to testing might have been overkill for this pr, but hopefully sets us up to do other complex testing with async-h1