Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support Distributed LogProb for GRPO Training #6247

Merged
merged 22 commits into from
Mar 18, 2025

Conversation

duanjunwen
Copy link
Member

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs
  • I have installed pre-commit: pip install pre-commit && pre-commit install

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@duanjunwen duanjunwen requested a review from a team as a code owner March 14, 2025 10:42
@duanjunwen duanjunwen requested a review from TongLi3701 March 17, 2025 01:25
Copy link
Member

@TongLi3701 TongLi3701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Junwen, I left some comments.

@TongLi3701
Copy link
Member

Please also compare the peak memory when using these two different methods.

@duanjunwen duanjunwen requested a review from TongLi3701 March 17, 2025 10:39
@duanjunwen
Copy link
Member Author

duanjunwen commented Mar 18, 2025

Please also compare the peak memory when using these two different methods.

We compared the case where the parallel output is True or False under strategy tp2zero1.
When parallel output is False, the peak mem is 93000+ MB (may suffer OOM when other users grab resources).
When parallel output is True, the peak mem is around 82000 MB.

Copy link
Member

@TongLi3701 TongLi3701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Junwen, I left some comments. Please address the comments and click on resolve conversation then request review again.

Thanks.

@duanjunwen duanjunwen requested a review from TongLi3701 March 18, 2025 03:55
@duanjunwen
Copy link
Member Author

Resolve Conflict.

@duanjunwen duanjunwen requested a review from TongLi3701 March 18, 2025 08:22
@duanjunwen duanjunwen requested a review from TongLi3701 March 18, 2025 09:32
@TongLi3701 TongLi3701 merged commit 7795d4c into hpcaitech:grpo-latest Mar 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants