Enhance and fix SPANK plugin #52
Open
+278
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This saves them from premature killing by psmgmt
- Requires Slurm 23.11 or later or a backport of this function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides fixing several bugs in the context of the SPANK plugin this PR mainly introduces the utilization of
spank_prepend_task_argv().spank_prepend_task_argv()was introduced in Slurm 23.11 and allows to manipulate the (to be spawned) task'sargvfrom within a SPANK plugin. This makes Spindle's SPANK plugin working again with Slurm 23.11 and above.It seams to me that the SPANK plugin broke once the tweaking of libc's jump table in
spindleHookSpindleArgsIntoExecBE()andinterceptExecForMap()stopped working due to making this table read-only.