Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

django.conf.urls.defaults fix for django 1.6+ #18

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions faq/admin.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ class QuestionAdmin(admin.ModelAdmin):
list_display = ['text', 'sort_order', 'created_by', 'created_on',
'updated_by', 'updated_on', 'status']
list_editable = ['sort_order', 'status']
raw_id_fields = ['created_by', 'updated_by']

def save_model(self, request, obj, form, change):
'''
Expand Down
4 changes: 2 additions & 2 deletions faq/managers.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ def active(self):
return self.filter(status__exact=self.model.ACTIVE)

class QuestionManager(models.Manager):
def get_query_set(self):
def get_queryset(self):
return QuestionQuerySet(self.model)

def active(self):
return self.get_query_set().active()
return self.get_queryset().active()
12 changes: 9 additions & 3 deletions faq/models.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,15 @@
import datetime
from django.db import models
from django.utils.translation import ugettext_lazy as _
from django.contrib.auth import get_user_model
from django.template.defaultfilters import slugify
from managers import QuestionManager
from django.conf import settings

if settings.USE_TZ:
from django.utils.timezone import now as datetime_now
else:
import datetime
datetime_now = datetime.datetime.now

User = get_user_model()

Expand Down Expand Up @@ -53,7 +59,7 @@ class Question(models.Model):
sort_order = models.IntegerField(_('sort order'), default=0,
help_text=_('The order you would like the question to be displayed.'))

created_on = models.DateTimeField(_('created on'), default=datetime.datetime.now)
created_on = models.DateTimeField(_('created on'), default=datetime_now)
updated_on = models.DateTimeField(_('updated on'))
created_by = models.ForeignKey(User, verbose_name=_('created by'),
null=True, related_name="+")
Expand All @@ -72,7 +78,7 @@ def __unicode__(self):

def save(self, *args, **kwargs):
# Set the date updated.
self.updated_on = datetime.datetime.now()
self.updated_on = datetime_now()

# Create a unique slug, if needed.
if not self.slug:
Expand Down
10 changes: 8 additions & 2 deletions faq/urls.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
from __future__ import absolute_import

from django.conf.urls.defaults import *
try:
# Django > 1.6
from django.conf.urls import patterns, include, url
except ImportError:
# Django < 1.6
from django.conf.urls.defaults import patterns, include, url

from . import views as faq_views

urlpatterns = patterns('',
Expand All @@ -24,4 +30,4 @@
view = faq_views.QuestionDetail.as_view(),
name = 'faq_question_detail',
),
)
)