Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate time in tray images #1501

Closed
wants to merge 3 commits into from
Closed

Conversation

hovancik
Copy link
Owner

closes #1478

@Wikiwix
Copy link
Contributor

Wikiwix commented Oct 20, 2024

The update is somewhat an improvement, but still not very legible and definitely not pretty.
I am currently looking into improving that based on that PR myself if that is okay for you?
I will concentrate on a monochrome aesthetic for now, I hope to have something to show soon.

A question that already came up for me:

  • How/where are the SVG base files transformed to the base PNG files?
    Having that within the script might give additional possibilities and reduce the places icons are created from.

@hovancik
Copy link
Owner Author

How/where are the SVG base files transformed to the base PNG files?

I believe I created them manually based on specifics for different OSes / trial error

@Wikiwix
Copy link
Contributor

Wikiwix commented Oct 20, 2024

A very first draft looks like this:
image

@Wikiwix
Copy link
Contributor

Wikiwix commented Oct 20, 2024

I have adapted the code (locally and not cleaned up yet), for the icons to look like this:

image

@hovancik should I prepare a complete change using this approach or do you dislike it?

I made some other improvements on the way:

  • limiting the width of the text
  • really (vertically) centering the text based on its actual dimensions

@Wikiwix
Copy link
Contributor

Wikiwix commented Oct 20, 2024

I add least put some of the change suggestions already into a branch (based on this branch): Wikiwix@b3927e1

@hovancik
Copy link
Owner Author

Looks nice! Please go ahead :)

@Wikiwix
Copy link
Contributor

Wikiwix commented Oct 21, 2024

Looks nice! Please go ahead :)

Alright, I will try to prepare the PR within this week :)

Should I just make a PR targeting trunk or should I make a PR targeting this PR's feature branch?

@hovancik
Copy link
Owner Author

feel free going for trunk

@Wikiwix Wikiwix mentioned this pull request Oct 28, 2024
9 tasks
@Wikiwix
Copy link
Contributor

Wikiwix commented Oct 28, 2024

Created a new PR: #1502

@hovancik hovancik closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request]: More legible remaining time in tray icon
2 participants