feat(secureHeader): add CSP Report-Only mode support #3413
Merged
+258
−235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isoppp
commented
Sep 14, 2024
Comment on lines
+227
to
+233
| describe.each([ | ||
| { cspSettingName: 'contentSecurityPolicy', cspHeaderName: 'Content-Security-Policy' }, | ||
| { | ||
| cspSettingName: 'contentSecurityPolicyReportOnly', | ||
| cspHeaderName: 'Content-Security-Policy-Report-Only', | ||
| }, | ||
| ])('CSP Setting ($cspSettingName)', ({ cspSettingName, cspHeaderName }) => { |
There was a problem hiding this comment.
Diff is crazy... but the following just adds this loop and moves the X-powered-by test to the top.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3413 +/- ##
=======================================
Coverage 95.77% 95.78%
=======================================
Files 154 154
Lines 9312 9322 +10
Branches 2730 2756 +26
=======================================
+ Hits 8919 8929 +10
Misses 393 393 ☔ View full report in Codecov by Sentry. |
|
Hi @isoppp Thank you for the PR! @watany-dev Can you review this? |
|
Thank you, I think this option looks good. The implementation also seems promising. |
|
@watany-dev Thank you! @isoppp Looks good! I'll merge this later. Since it's a small change, it may be included in the next patch release. |
isoppp
changed the title
This was referenced Oct 17, 2024
TinsFox
pushed a commit
to TinsFox/hono
that referenced
this pull request
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3412
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code