Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade devcontainer to latest #162

Merged
merged 2 commits into from
Feb 3, 2025
Merged

upgrade devcontainer to latest #162

merged 2 commits into from
Feb 3, 2025

Conversation

jkt628
Copy link
Contributor

@jkt628 jkt628 commented Feb 2, 2025

Fixes #161

agners
agners requested changes Feb 3, 2025
View reviewed changes
@home-assistant home-assistant bot marked this pull request as draft February 3, 2025 08:25
@home-assistant
Copy link

home-assistant bot commented Feb 3, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@jkt628 jkt628 marked this pull request as ready for review February 3, 2025 08:44
@home-assistant home-assistant bot requested a review from agners February 3, 2025 08:44
frenck
frenck approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jkt628 👍

../Frenck

agners
agners approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@agners agners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda weird that the first run lead to a gcc: internal compiler error: Segmentation fault signal terminated program cc1 🤔

Since the devcontainer should not affect the build at all, this can't be the culprit. I guess a GitHub action hickup.

@agners agners merged commit f784217 into home-assistant:master Feb 3, 2025
9 checks passed
@jkt628 jkt628 deleted the jkt628/issue161 branch February 3, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agners agners agners approved these changes

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

devcontainer fails
3 participants
@jkt628 @agners @frenck