Migrate LocationHistoryList to SwiftUI

[banaslee]

Summary

In this PR I set to migrate the LocationHistoryList to SwiftUI, to reduce the dependency in Eureka. This screen was picked at random.

As this screen is presented from two different places, SettingsDetail and Debug screens, also updated the code in the corresponding classes.

The LocationHistory list reacts to changes.

LocationHistoryDetail

LocationHistoryDetailViewController also gained a SwiftUI wrapper in order for it to be presented from the new LocationHistoryListView.
This wrapper syncs the navigation items between the wrapped View Controller and the parent.
Move functionality also got migrated.

Misc changes

• Support for M4 added to the Gemfile.lock (added automatically)
• New extension for safe subscripting in arrays added.

Screenshots

LocationHistoryList item

Empty LocationHistoryList

[home-assistant]

Hi @banaslee

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Stale

[banaslee]

Moving back to draft as the Move functionality was missed.

[banaslee]

Move functionality has been restored. Works differently than before by reusing the same LocationHistoryDetailViewController instance and updating the entry and, consequently, the UI.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.33%. Comparing base (6c34210) to head (9e20c5a).
Report is 549 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #3468       +/-   ##
===========================================
+ Coverage   27.54%   45.33%   +17.78%     
===========================================
  Files         311      221       -90     
  Lines       31699    13309    -18390     
===========================================
- Hits         8733     6033     -2700     
+ Misses      22966     7276    -15690     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bgoncal]

Thanks for your contribution, I'll run the app today to give it a try, but in general it looks good, are you going to migrate LocationHistoryDetailViewController afterwards?

Also, sorry for the timin, but I am leaving on vacations until March 13th, so if you don't hear from me, thats the reason.

[bgoncal]

For linting bundle exec fastlane autocorrect

[banaslee]

Thanks for your contribution, I'll run the app today to give it a try, but in general it looks good, are you going to migrate LocationHistoryDetailViewController afterwards?

Yes, that's my plan. It's not clear how the map support is in SwiftUI for minimum supported version but will see when I get there. I don't think I'll be blocked.

I ran it in the iOS and iPad simulators against my instance and looked good. Can you please validate if the current location annotation stays after moving between entries?

Also, sorry for the timin, but I am leaving on vacations until March 13th, so if you don't hear from me, thats the reason.

No worries. Enjoy your time off.

[banaslee]

@bgoncal applied your requested changes plus improved the previews by introducing more mock data and names.

[bgoncal]

Can you add a small test for the safe subscript extension you added? Also one snapshot test for the view, I started with snapshot tests very recently so probably the only place you will find example is WidgetsSnapshotTests

Im running on my phone now and it all looks good, I will let you know in case I spot something

[banaslee]

@bgoncal I'm going to push snapshots in light mode for now.

How interesting would it be if I pushed a change in a new PR to always generate and assert in dark mode as well?

[bgoncal]

That's would be nice! We should aim for that indeed

[banaslee]

Heads up @bgoncal, the test may need to be updated to use the latest SDK version, 18.2. At least it's failing to find a valid platform on the CI

[20:59:20]: ▸ xcodebuild: error: Unable to find a destination matching the provided destination specifier:
[20:59:20]: ▸ 		{ platform:iOS Simulator, OS:18.1, name:iPhone 16 }
[20:59:20]: ▸ 	Available destinations for the "Tests-Unit" scheme:
[20:59:20]: ▸ 		{ platform:macOS, arch:arm64, variant:Mac Catalyst, id:0000FE00-0D2881097313F0FA, name:My Mac }
[20:59:20]: ▸ 		{ platform:macOS, arch:x86_64, variant:Mac Catalyst, id:0000FE00-0D2881097313F0FA, name:My Mac }
[20:59:20]: ▸ 		{ platform:macOS, variant:Mac Catalyst, name:Any Mac }
[20:59:20]: ▸ 	Ineligible destinations for the "Tests-Unit" scheme:
[20:59:20]: ▸ 		{ platform:iOS, id:dvtdevice-DVTiPhonePlaceholder-iphoneos:placeholder, name:Any iOS Device, error:iOS 18.2 is not installed. To use with Xcode, first download and install the platform }

[banaslee]

That's would be nice! We should aim for that indeed

Cool, once we merge this one I have two more lined up with improvements to the snapshot tests tooling.