Support intent-progress for Assist #5132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgoncal
approved these changes
Mar 19, 2025
| is AssistEvent.MessageChunk -> { | ||
| val lastMessage = _conversation.last() | ||
| if (lastMessage == haMessage) { | ||
| // Remove '...' message and add the chunk received |
There was a problem hiding this comment.
In iOS I have a "typing" animation while we don't get a response, perhaps something you could add in a future PR
jpelgrom
reviewed
Mar 19, 2025
| @@ -40,6 +41,14 @@ data class AssistPipelineIntentStart( | |||
| val intentInput: String | |||
| ) : AssistPipelineEventData | |||
|
|
|||
| @JsonIgnoreProperties(ignoreUnknown = true) | |||
| data class AssistPipelineIntentProgress( | |||
| val chat_log_delta: AssistChatLogDelta? | |||
There was a problem hiding this comment.
Suggested change
| val chat_log_delta: AssistChatLogDelta? | |
| val chatLogDelta: AssistChatLogDelta? |
Doesn't this work? The code base uses camel case, Jackson will convert the snake case from the API.
There was a problem hiding this comment.
Indeed I was too fast while copy pasting from JSON.
There was a problem hiding this comment.
Any reason to not have a tool that check for this kind of thing?
jpelgrom
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
intent-progressallow streaming the answer of a LLM, right now it is not playing the sound before the text is fully written but that's a limitation of the API nothing we can do in the app.This PR is inspired by iOS PR home-assistant/iOS#3483 and the frontend PR home-assistant/frontend#24143
The frontend is handling the
rolebut it seems that in our case we don't need for now at least.I took the liberty to replace the callback with unnamed arguments with a sealed class for better usability and evolution.
Screenshots
demo_stream.webm
Any other notes
It only works with ChatGPT integration for now.