Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document events + one alteration for consistency #31

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

document events + one alteration for consistency #31

wants to merge 1 commit into from

Conversation

davidmarkclements
Copy link
Contributor

  • document new leave and join events
  • alter the update event to use pass key instead of { key }

@mafintosh
Copy link
Contributor

@andrewosh anything here we should port in?

@andrewosh
Copy link
Contributor

Let's leave this open for now, because the new PeerDiscovery object doesn't emit anything equivalent to the updated event currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mafintosh mafintosh Awaiting requested review from mafintosh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidmarkclements @mafintosh @andrewosh