Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/feedback: remove flag shorthands that are conflicting with global flags #399

Merged
merged 1 commit into from
Dec 15, 2024
Merged

cmd/feedback: remove flag shorthands that are conflicting with global flags #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .hof/shadow/cli/cmd/hof/flags/feedback.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ type FeedbackPflagpole struct {
func SetupFeedbackPflags(fset *pflag.FlagSet, fpole *FeedbackPflagpole) {
// pflags

fset.BoolVarP(&(fpole.Issue), "issue", "I", false, "create an issue (discussion is default)")
fset.StringVarP(&(fpole.Labels), "labels", "L", "feedback", "labels,comma,separated")
fset.BoolVarP(&(fpole.Issue), "issue", "", false, "create an issue (discussion is default)")
fset.StringVarP(&(fpole.Labels), "labels", "", "feedback", "labels,comma,separated")
}

var FeedbackPflags FeedbackPflagpole
Expand Down
4 changes: 2 additions & 2 deletions cmd/hof/flags/feedback.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ type FeedbackPflagpole struct {
func SetupFeedbackPflags(fset *pflag.FlagSet, fpole *FeedbackPflagpole) {
// pflags

fset.BoolVarP(&(fpole.Issue), "issue", "I", false, "create an issue (discussion is default)")
fset.StringVarP(&(fpole.Labels), "labels", "L", "feedback", "labels,comma,separated")
fset.BoolVarP(&(fpole.Issue), "issue", "", false, "create an issue (discussion is default)")
fset.StringVarP(&(fpole.Labels), "labels", "", "feedback", "labels,comma,separated")
}

var FeedbackPflags FeedbackPflagpole
Expand Down
4 changes: 2 additions & 2 deletions design/cmds/feedback.cue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@ FeedbackCommand: schema.Command & {
Pflags: [{
Name: "issue"
Long: "issue"
Short: "I"
Short: ""
Type: "bool"
Default: "false"
Help: "create an issue (discussion is default)"
}, {
Name: "labels"
Long: "labels"
Short: "L"
Short: ""
Type: "string"
Default: "\"feedback\""
Help: "labels,comma,separated"
Expand Down
Loading