Add docs for OIDC checks #1062
Merged
Add docs for OIDC checks #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviadhahami
approved these changes
Jan 24, 2025
docs/en/enterprise-edition/policy-reference/aws-policies/aws-iam-policies/iam-358.adoc
Outdated
Show resolved
Hide resolved
docs/en/enterprise-edition/policy-reference/aws-policies/aws-iam-policies/iam-358.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Aviad Hahami <[email protected]>
docs/en/enterprise-edition/policy-reference/aws-policies/aws-iam-policies/iam-358.adoc
Show resolved
Hide resolved
docs/en/enterprise-edition/policy-reference/aws-policies/aws-iam-policies/iam-358.adoc
Outdated
Show resolved
Hide resolved
docs/en/enterprise-edition/policy-reference/aws-policies/aws-iam-policies/iam-358.adoc
Outdated
Show resolved
Hide resolved
docs/en/enterprise-edition/policy-reference/aws-policies/aws-iam-policies/iam-358.adoc
Outdated
Show resolved
Hide resolved
docs/en/enterprise-edition/policy-reference/aws-policies/aws-iam-policies/iam-358.adoc
Show resolved
Hide resolved
docs/en/enterprise-edition/policy-reference/azure-policies/azure-iam-policies/azr-iam-249.adoc
Show resolved
Hide resolved
| - Uses a specific repository reference. | ||
|
|
||
|
|
||
| Example: |
There was a problem hiding this comment.
@tsmithv11 Move Example above Terraform in line 33 as the entire block starting from line 33 is an example
There was a problem hiding this comment.
Not sure I agree. The top part of the remediation is a description of the remediations. The Terraform code below is the actual example.
...se-edition/policy-reference/google-cloud-policies/google-cloud-iam-policies/gcp-iam-125.adoc
Outdated
Show resolved
Hide resolved
...se-edition/policy-reference/google-cloud-policies/google-cloud-iam-policies/gcp-iam-125.adoc
Outdated
Show resolved
Hide resolved
| - Ensures claims follow safe and restricted formats. | ||
| - Uses a specific repository reference. | ||
|
|
||
| Example: |
There was a problem hiding this comment.
Move above Terraform in line 39 (line 38), as the entire block is an example
There was a problem hiding this comment.
See my other comment. I don't believe we should as the description above is for all scenarios the code below is the example.
|
Merge as per @tsmithv11's request from 25.02.2025 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs: