[#449] use weak properties for delegates

hivewallet · Mar 29, 2015 · 5ab89d0 · 5ab89d0
1 parent f9393a4
commit 5ab89d0
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 7 deletions.
diff --git a/Hive/Controllers/HICameraWindowController.h b/Hive/Controllers/HICameraWindowController.h
@@ -12,7 +12,7 @@
  */
 @interface HICameraWindowController : NSWindowController
 
-@property (nonatomic, strong) id<HICameraWindowControllerDelegate> delegate;
+@property (nonatomic, weak) id<HICameraWindowControllerDelegate> delegate;
 
 + (HICameraWindowController *)sharedCameraWindowController;
 

diff --git a/Hive/Controllers/HIContactAutocompleteWindowController.h b/Hive/Controllers/HIContactAutocompleteWindowController.h
@@ -21,7 +21,7 @@
 
 @interface HIContactAutocompleteWindowController : NSWindowController <NSTableViewDelegate>
 
-@property (nonatomic, unsafe_unretained) id<HIContactAutocompleteDelegate> delegate;
+@property (nonatomic, weak) id<HIContactAutocompleteDelegate> delegate;
 
 - (void)searchWithContact:(HIContact *)contact;
 - (void)searchWithQuery:(NSString *)query;

diff --git a/Hive/Controllers/HIContactTabBarController.m b/Hive/Controllers/HIContactTabBarController.m
@@ -15,7 +15,7 @@ @interface HIContactTabBarController () {
     NSArray *_tabBarButtons;
 }
 
-@property (nonatomic, strong) IBOutlet id<HIProfileTabBarControllerDelegate> tabDelegate;
+@property (nonatomic, weak) IBOutlet id<HIProfileTabBarControllerDelegate> tabDelegate;
 
 @end
 

diff --git a/Hive/Controllers/HISidebarController.m b/Hive/Controllers/HISidebarController.m
@@ -32,7 +32,7 @@ @interface HISidebarController () {
 
 @property (nonatomic, weak) IBOutlet NSView *view;
 @property (nonatomic, weak) IBOutlet NSButton *sendButton;
-@property (nonatomic, unsafe_unretained) IBOutlet id<HISidebarControllerDelegate> delegate;
+@property (nonatomic, weak) IBOutlet id<HISidebarControllerDelegate> delegate;
 
 @property (nonatomic, assign) NSInteger selectedTabIndex;
 

diff --git a/Hive/Controllers/HITransactionPopoverViewController.h b/Hive/Controllers/HITransactionPopoverViewController.h
@@ -17,7 +17,7 @@
 
 @interface HITransactionPopoverViewController : NSViewController
 
-@property (nonatomic, strong) id<HITransactionPopoverDelegate> delegate;
+@property (nonatomic, weak) id<HITransactionPopoverDelegate> delegate;
 
 - (instancetype)initWithTransaction:(HITransaction *)transaction;
 - (NSPopover *)createPopover;

diff --git a/Hive/Controllers/HIWizardViewController.h b/Hive/Controllers/HIWizardViewController.h
@@ -14,7 +14,7 @@
 
 @interface HIWizardViewController : NSViewController
 
-@property (nonatomic, strong) id<HIWizardViewControllerDelegate> wizardDelegate;
+@property (nonatomic, weak) id<HIWizardViewControllerDelegate> wizardDelegate;
 @property (nonatomic, strong, readonly) NSResponder *initialFirstResponder;
 
 - (void)viewWillAppear;

diff --git a/Hive/Views/HITitleView.h b/Hive/Views/HITitleView.h
@@ -27,7 +27,7 @@
 
 @interface HITitleView : NSView
 
-@property (nonatomic, unsafe_unretained) id<HITitleViewDelegate> delegate;
+@property (nonatomic, weak) id<HITitleViewDelegate> delegate;
 
 - (void)pushTitle:(NSString *)title;
 - (void)popToTitleAtPosition:(NSInteger)position;
-Original file line number
+Diff line change
@@ Expand Up / @@ -15,7 +15,7 @@ @interface HIContactTabBarController () { @@
         NSArray *_tabBarButtons;
     }
-    @property (nonatomic, strong) IBOutlet id<HIProfileTabBarControllerDelegate> tabDelegate;
+    @property (nonatomic, weak) IBOutlet id<HIProfileTabBarControllerDelegate> tabDelegate;
     @end
@@ Expand Down @@