Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Rewrite XML Parsing for Query Recordsets #31

Merged
merged 6 commits into from
Mar 16, 2016

Conversation

StevenMMortimer
Copy link
Contributor

This request changes the package to use one function called query_parser when parsing the results returned by Salesforce from SOQL queries. This was done to better handle foreign object and child-parent nested relationships that SOQL queries can return.

I believe this methodology or another methodology should be deployed soon in order to quickly resolve the backlog of issues described in #23

Link to query_parser code:
https://github.com/ReportMort/RForcecom/blob/query-refactor/R/rforcecom.utils.R

Change the internal behavior of rforcecom.query to handle nested queries, obey global options setting for stringsAsFactors, and increase speed.
Fix code to loop through each list column because there might be a list for each foreign object that's being referenced
Change the internal behavior of rforcecom.query to handle nested queries, obey global options setting for stringsAsFactors, and increase speed.
Fix code to loop through each list column because there might be a list for each foreign object that's being referenced
@ax42
Copy link
Contributor

ax42 commented Feb 16, 2016

We're seeing the same issue -- would be great if this pull request could be integrated asap.

hiratake55 added a commit that referenced this pull request Mar 16, 2016
Rewrite XML Parsing for Query Recordsets
@hiratake55 hiratake55 merged commit 7249d2d into hiratake55:master Mar 16, 2016
@nelsonauner
Copy link

@ReportMort
After getting the same error as described in #23 (Error: All inputs to rbind.fill must be data.frames) , I now get a new error:

Error in t.default(unlist(x[setdiff(seq.int(length(x)), c(list_col, attr_col))])) : argument is not a matrix

Is there an easy fix for this?
If not, I can open an issue + put in more steps to reproduce

@hiratake55
Copy link
Owner

@nelsonauner The patch merged but it is not on the CRAN now. Please try the code from github or please wait just a few days, I will upload the current head version to CRAN.

@nelsonauner
Copy link

@hiratake55
This error was encountered with RForcecom_0.9
installed today using github_install("hiratake55/RForcecom")

@StevenMMortimer
Copy link
Contributor Author

@nelsonauner Could you add some more detail and we'll go from there? Thanks.

@nelsonauner
Copy link

@ReportMort @hiratake55
Sure, I've opened an issue at #37

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants