Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update reaction deletion logic and improve test assertions #9902

Merged
merged 3 commits into from
Nov 14, 2024
Merged

fix: update reaction deletion logic and improve test assertions #9902

merged 3 commits into from
Nov 14, 2024

Conversation

ilijabojanovic
Copy link
Collaborator

@ilijabojanovic ilijabojanovic commented Nov 14, 2024 •
edited
Loading

Link to Issue

Closes: #9904

Description of Changes

  • Adds FIXME widget to TODO page.

"How We Fixed It"

Test Plan

  • Unit tested the FIXME() call.
  • CA (click around) tested on local and frack:
    • TODO page

Deployment Plan

Other Considerations

@github-actions github-actions bot marked this pull request as draft November 14, 2024 13:24
@ilijabojanovic ilijabojanovic marked this pull request as ready for review November 14, 2024 14:41
@ilijabojanovic ilijabojanovic merged commit 6b07853 into release/v1.7.3-x Nov 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timolegros timolegros Awaiting requested review from timolegros

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ilijabojanovic